Changeset 4102 for palm/trunk/SOURCE/chemistry_model_mod.f90

Timestamp:

Jul 17, 2019 4:00:03 PM (5 years ago)

Author:

suehring

Message:

Bugfix, set Neumann boundary conditions for the subgrid TKE at vertical walls instead of implicit Dirichlet conditions that always act as a sink term for the subgrid TKE. Therefore, add new data structure for vertical surfaces and revise the setting of the boundary grid point index space. Moreover, slightly revise setting of boundary conditions at upward- and downward facing surfaces. Finally, setting of boundary conditions for subgrid TKE and dissipation (in RANS mode) is now modularized. Update test case results.

File:

• palm/trunk/SOURCE/chemistry_model_mod.f90 (modified) (6 diffs)

palm/trunk/SOURCE/chemistry_model_mod.f90

@@ -27 +27 @@
 ! -----------------
 ! $Id$
+! Slightly revise setting of boundary conditions at horizontal walls, use 
+! data-structure offset index instead of pre-calculate it for each facing
+! 
+! 4080 2019-07-09 18:17:37Z suehring
 ! Restore accidantly removed limitation to positive values
 ! 
@@ -804 +808 @@
     INTEGER(iwp) ::  j                            !< grid index y direction.
     INTEGER(iwp) ::  k                            !< grid index z direction.
-    INTEGER(iwp) ::  kb                           !< variable to set respective boundary value, depends on facing. 
     INTEGER(iwp) ::  l                            !< running index boundary type, for up- and downward-facing walls.
     INTEGER(iwp) ::  m                            !< running index surface elements.
@@ -839 +842 @@
        CASE ( 'set_bc_bottomtop' )                   
 !
-!--          Bottom boundary condtions for chemical species      
+!--       Boundary condtions for chemical species at horizontal walls      
           DO  lsp = 1, nspec                                                      
-             IF ( ibc_cs_b == 0 )  THEN                   
+             IF ( ibc_cs_b == 0 )  THEN
                 DO  l = 0, 1 
-!
-!--                Set index kb: For upward-facing surfaces (l=0), kb=-1, i.e.
-!--                the chem_species(nspec)%conc_p value at the topography top (k-1)
-!--                is set; for downward-facing surfaces (l=1), kb=1, i.e. the 
-!--                value at the topography bottom (k+1) is set. 
-
-                   kb = MERGE( -1, 1, l == 0 )
                    !$OMP PARALLEL DO PRIVATE( i, j, k )
                    DO  m = 1, bc_h(l)%ns
@@ -855 +851 @@
                        j = bc_h(l)%j(m)
                        k = bc_h(l)%k(m)
-                      chem_species(lsp)%conc_p(k+kb,j,i) = chem_species(lsp)%conc(k+kb,j,i) 
+                      chem_species(lsp)%conc_p(k+bc_h(l)%koff,j,i) =           &
+                                      chem_species(lsp)%conc(k+bc_h(l)%koff,j,i) 
                    ENDDO                                        
                 ENDDO                                       
@@ -863 +860 @@
 !--             in boundary_conds there is som extra loop over m here for passive tracer
                 DO  l = 0, 1
-                   kb = MERGE( -1, 1, l == 0 )
                    !$OMP PARALLEL DO PRIVATE( i, j, k )                                           
                    DO m = 1, bc_h(l)%ns
@@ -869 +865 @@
                       j = bc_h(l)%j(m)
                       k = bc_h(l)%k(m)
-                      chem_species(lsp)%conc_p(k+kb,j,i) = chem_species(lsp)%conc_p(k,j,i)
+                      chem_species(lsp)%conc_p(k+bc_h(l)%koff,j,i) =           &
+                                         chem_species(lsp)%conc_p(k,j,i)
 
                    ENDDO