Changeset 85

Timestamp:

May 11, 2007 9:35:14 AM (17 years ago)

Author:

raasch

Message:

openmp bugfixes found by NEC benchmarker

Location:

palm/trunk/SOURCE

Files:

• CURRENT_MODIFICATIONS (modified) (1 diff)
• poisfft.f90 (modified) (5 diffs)
• pres.f90 (modified) (10 diffs)

palm/trunk/SOURCE/CURRENT_MODIFICATIONS

@@ -5 +5 @@
 Changed:
 -------
+Division through dt_3d replaced by multiplication of the inverse. For performance optimisation, this is done in the loop calculating the divergence instead of using a seperate loop. (pres.f90)
+
+pres
 
 
 Errors:
 ------
+Bugfix: work_fft*_vec removed from some PRIVATE-declarations (poisfft.f90).
+
+poisfft

palm/trunk/SOURCE/poisfft.f90

@@ -4 +4 @@
 ! Actual revisions:
 ! -----------------
-! 
+! Bugfix: work_fft*_vec removed from some PRIVATE-declarations
 !
 ! Former revisions:
@@ -641 +641 @@
 !
 !--       Code optimized for vector processors
-!$OMP     PARALLEL PRIVATE ( i, j, k, work_ffty_vec )
+!$OMP     PARALLEL PRIVATE ( i, j, k )
 !$OMP     DO
           DO  i = nxl, nxr
@@ -763 +763 @@
 !
 !--       Code optimized for vector processors
-!$OMP     PARALLEL PRIVATE ( i, j, k, work_ffty_vec )
+!$OMP     PARALLEL PRIVATE ( i, j, k )
 !$OMP     DO
           DO  k = 1, nz
@@ -1003 +1003 @@
 !
 !--       Code for vector processors
-!$OMP     PARALLEL PRIVATE ( i, j, k, work_fftx )
+!$OMP     PARALLEL PRIVATE ( i, j, k )
 !$OMP     DO
           DO  i = 0, nx
@@ -1114 +1114 @@
 !
 !--       Code optimized for vector processors
-!$OMP     PARALLEL PRIVATE ( i, j, k, work_fftx )
+!$OMP     PARALLEL PRIVATE ( i, j, k )
 !$OMP     DO
           DO  j = nys, nyn

palm/trunk/SOURCE/pres.f90

@@ -4 +4 @@
 ! Actual revisions:
 ! -----------------
-! 
+! Division through dt_3d replaced by multiplication of the inverse.
+! For performance optimisation, this is done in the loop calculating the
+! divergence instead of using a seperate loop.
 !
 ! Former revisions:
@@ -48 +50 @@
     INTEGER ::  i, j, k, sr
 
-    REAL    ::  localsum, threadsum
+    REAL    ::  ddt_3d, localsum, threadsum
 
     REAL, DIMENSION(1:2) ::  volume_flow_l, volume_flow_offset
@@ -55 +57 @@
 
     CALL cpu_log( log_point(8), 'pres', 'start' )
+
+
+    ddt_3d = 1.0 / dt_3d
 
 !
@@ -167 +172 @@
        DO  j = nys, nyn
           DO  k = nzb_s_inner(j,i)+1, nzt
-             d(k,j,i) = ( u(k,j,i+1) - u(k,j,i) ) * ddx + &
-                        ( v(k,j+1,i) - v(k,j,i) ) * ddy + &
-                        ( w(k,j,i) - w(k-1,j,i) ) * ddzw(k)
+             d(k,j,i) = ( ( u(k,j,i+1) - u(k,j,i) ) * ddx + &
+                          ( v(k,j+1,i) - v(k,j,i) ) * ddy + &
+                          ( w(k,j,i) - w(k-1,j,i) ) * ddzw(k) ) * ddt_3d
           ENDDO
 !
@@ -184 +189 @@
                                        - g * ( pt(k+1,j,i) - sums(k+1,4) ) / &
                                          sums(k+1,4)                         &
-                                       ) * ddzw(k+1)
+                                       ) * ddzw(k+1) * ddt_3d
           ENDIF
 
@@ -193 +198 @@
           ENDDO
 
-!
-!--       Velocity corrections are made with Euler step size. Right hand side
-!--       of Poisson equation has to be set appropriately
-          DO  k = nzb_s_inner(j,i)+1, nzt
-             d(k,j,i) = d(k,j,i) / dt_3d
-          ENDDO
-
        ENDDO
     ENDDO
 
-    localsum = localsum + threadsum
+    localsum = ( localsum + threadsum ) * dt_3d
     !$OMP END PARALLEL
 #else
@@ -212 +210 @@
           DO  j = nys, nyn
              DO  k = nzb_s_inner(j,i)+1, nzt
-                d(k,j,i) = ( u(k,j,i+1) - u(k,j,i) ) * ddx + &
-                           ( v(k,j+1,i) - v(k,j,i) ) * ddy + &
-                           ( w(k,j,i) - w(k-1,j,i) ) * ddzw(k)
+                d(k,j,i) = ( ( u(k,j,i+1) - u(k,j,i) ) * ddx + &
+                             ( v(k,j+1,i) - v(k,j,i) ) * ddy + &
+                             ( w(k,j,i) - w(k-1,j,i) ) * ddzw(k) ) * ddt_3d
              ENDDO
           ENDDO
@@ -230 +228 @@
                            - g * ( pt(k+1,j,i) - sums(k+1,4) ) / &
                              sums(k+1,4)                         &
-                                        ) * ddzw(k+1)
+                                        ) * ddzw(k+1) * ddt_3d
           ENDDO
        ENDDO
@@ -242 +240 @@
           DO  j = nys, nyn
              DO  k = nzb_s_inner(j,i)+1, nzt
-                d(k,j,i) = ( u(k,j,i+1) - u(k,j,i) ) * ddx + &
-                           ( v(k,j+1,i) - v(k,j,i) ) * ddy + &
-                           ( w(k,j,i) - w(k-1,j,i) ) * ddzw(k)
+                d(k,j,i) = ( ( u(k,j,i+1) - u(k,j,i) ) * ddx + &
+                             ( v(k,j+1,i) - v(k,j,i) ) * ddy + &
+                             ( w(k,j,i) - w(k-1,j,i) ) * ddzw(k) ) * ddt_3d
              ENDDO
           ENDDO
@@ -263 +261 @@
        ENDDO
     ENDDO
-    localsum = localsum + threadsum
+    localsum = ( localsum + threadsum ) * dt_3d
     !$OMP END PARALLEL
-
-!
-!-- Velocity corrections are made with Euler step size. Right hand side
-!-- of Poisson equation has to be set appropriately
-    !$OMP DO SCHEDULE( STATIC )
-    DO  i = nxl, nxr
-       DO  j = nys, nyn
-          DO  k = nzb_s_inner(j,i)+1, nzt
-             d(k,j,i) = d(k,j,i) / dt_3d
-          ENDDO
-       ENDDO
-    ENDDO
 #endif