Changeset 4833 for palm

Timestamp:

Jan 7, 2021 8:57:54 AM (4 years ago)

Author:

raasch

Message:

openmp bugfix for time measurements of non advective processes

File:

• palm/trunk/SOURCE/chemistry_model_mod.f90 (modified) (3 diffs)

palm/trunk/SOURCE/chemistry_model_mod.f90

@@ -26 +26 @@
 ! -----------------
 ! $Id$
+! openmp bugfix for time measurements of non advective processes 
+!
+! 4828 2021-01-05 11:21:41Z Giersch
 ! reading of namelist file and actions in case of namelist errors revised so that statement labels
 ! and goto statements are not required any more
@@ -2900 +2903 @@
       ENDIF
 
-
-
     END SUBROUTINE chem_non_advective_processes
 
@@ -2913 +2914 @@
 
 
-   INTEGER(iwp), INTENT(IN) ::  i  !< grid index in x-direction
-   INTEGER(iwp), INTENT(IN) ::  j  !< grid index in y-direction
+    INTEGER(iwp), INTENT(IN) ::  i  !< grid index in x-direction
+    INTEGER(iwp), INTENT(IN) ::  j  !< grid index in y-direction
 
 !
 !-- Calculation of chemical reactions and deposition.
-   IF ( intermediate_timestep_count == 1  .OR.  call_chem_at_all_substeps )  THEN
-
-      IF ( chem_gasphase_on )  THEN
-         CALL cpu_log( log_point_s(19), 'chem.reactions', 'start' )
-         CALL chem_integrate( i, j )
-         CALL cpu_log( log_point_s(19), 'chem.reactions', 'stop' )
-      ENDIF
-
-      IF ( deposition_dry )  THEN
-         CALL cpu_log( log_point_s(24), 'chem.deposition', 'start' )
-         CALL chem_depo( i, j )
-         CALL cpu_log( log_point_s(24), 'chem.deposition', 'stop' )
-      ENDIF
-
-   ENDIF
-
-
+!-- !> TODO
+!-- WARNING: time measurements within i,j loops degrade performance because cpu-log routine is
+!--          called extremely often. Furthermore, because of that, the counter for this measurement
+!--          will get an extremely huge value, too.
+!--          Should be removed, because in other _ij routines no measurements are done because of
+!--          the reasons given above.
+    IF ( intermediate_timestep_count == 1  .OR.  call_chem_at_all_substeps )  THEN
+
+       IF ( chem_gasphase_on )  THEN
+          !$OMP MASTER
+          CALL cpu_log( log_point_s(19), 'chem.reactions', 'start' )
+          !$OMP END MASTER
+          CALL chem_integrate( i, j )
+          !$OMP MASTER
+          CALL cpu_log( log_point_s(19), 'chem.reactions', 'stop' )
+          !$OMP END MASTER
+       ENDIF
+
+       IF ( deposition_dry )  THEN
+          !$OMP MASTER
+          CALL cpu_log( log_point_s(24), 'chem.deposition', 'start' )
+          !$OMP END MASTER
+          CALL chem_depo( i, j )
+          !$OMP MASTER
+          CALL cpu_log( log_point_s(24), 'chem.deposition', 'stop' )
+          !$OMP END MASTER
+       ENDIF
+
+    ENDIF
 
  END SUBROUTINE chem_non_advective_processes_ij
+
 
 !--------------------------------------------------------------------------------------------------!