Changeset 4692 for palm

Timestamp:

Sep 22, 2020 5:17:52 PM (4 years ago)

Author:

maronga

Message:

minor bugfix in urban surface model, further update of output for urban_environment_salsa test case

Location:

palm/trunk

Files:

• SOURCE/urban_surface_mod.f90 (modified) (2 diffs)
• TESTS/cases/urban_environment_salsa/OUTPUT/urban_environment_salsa_pr.000.nc (modified) (previous)

palm/trunk/SOURCE/urban_surface_mod.f90

@@ -27 +27 @@
 ! -----------------
 ! $Id$
+! Bugfix for previous revision
+!
+! 4687 2020-09-21 19:40:16Z maronga
 ! Optimized code structure for treatment of inner wall and window heat flux
 !
@@ -5200 +5203 @@
 !--    heat diffusion (innermost wall temperature as boundary conditions)
        IF ( .NOT. indoor_model ) THEN
-          surf%iwghf_eb(m) = - surf%lambda_h(nzt_wall-1,m) * ( t_wall%val(nzt_wall,m) &
-                             - t_wall%val(nzt_wall-1,m) ) * surf%ddz_wall(nzt_wall,m)
-          ENDIF
-
-          DO  kw = nzb_wall+1, nzt_wall-1
-             wtend(kw) = ( 1.0_wp / surf%rho_c_wall(kw,m) )                             &
-                         * ( surf%lambda_h(kw,m) * wall_mod(kw)                         &
-                             * ( t_wall%val(kw+1,m) - t_wall%val(kw,m) )                &
-                             * surf%ddz_wall(kw+1,m)                                    &
-                             - surf%lambda_h(kw-1,m) * wall_mod(kw-1)                   &
-                             * ( t_wall%val(kw,m) - t_wall%val(kw-1,m) )                &
-                             * surf%ddz_wall(kw,m)                                      &
-                           ) * surf%ddz_wall_stag(kw,m)
-          ENDDO
-          wtend(nzt_wall) = ( 1.0_wp / surf%rho_c_wall(nzt_wall,m) )                    &
-                            * ( -surf%lambda_h(nzt_wall-1,m) * wall_mod(nzt_wall-1)     &
-                                * ( t_wall%val(nzt_wall,m) - t_wall%val(nzt_wall-1,m) ) &
-                                * surf%ddz_wall(nzt_wall,m)                             &
-                                + surf%iwghf_eb(m)                                      &
-                              ) * surf%ddz_wall_stag(nzt_wall,m)
+          surf%iwghf_eb(m) = - surf%lambda_h(nzt_wall-1,m) * wall_mod(kw-1)           &
+                             * ( t_wall%val(nzt_wall,m) - t_wall%val(nzt_wall-1,m) )  &
+                             * surf%ddz_wall(nzt_wall,m)
+       ENDIF
+
+       DO  kw = nzb_wall+1, nzt_wall-1
+          wtend(kw) = ( 1.0_wp / surf%rho_c_wall(kw,m) )                         &
+                      * ( surf%lambda_h(kw,m) * wall_mod(kw)                     &
+                      * ( t_wall%val(kw+1,m) - t_wall%val(kw,m) )                &
+                      * surf%ddz_wall(kw+1,m)                                    &
+                      - surf%lambda_h(kw-1,m) * wall_mod(kw-1)                   &
+                      * ( t_wall%val(kw,m) - t_wall%val(kw-1,m) )                &
+                      * surf%ddz_wall(kw,m)                                      &
+                      ) * surf%ddz_wall_stag(kw,m)
+       ENDDO
+       wtend(nzt_wall) = ( 1.0_wp / surf%rho_c_wall(nzt_wall,m) )                    &
+                         * ( -surf%lambda_h(nzt_wall-1,m) * wall_mod(nzt_wall-1)     &
+                             * ( t_wall%val(nzt_wall,m) - t_wall%val(nzt_wall-1,m) ) &
+                              * surf%ddz_wall(nzt_wall,m) + surf%iwghf_eb(m)         &
+                           ) * surf%ddz_wall_stag(nzt_wall,m)
 
        t_wall_p%val(nzb_wall:nzt_wall,m) = t_wall%val(nzb_wall:nzt_wall,m) + dt_3d      &