Changeset 4154

Timestamp:

Aug 13, 2019 1:35:59 PM (5 years ago)

Author:

suehring

Message:

Bugfix in chemistry decycling; Replace global arrays to setup chemical emissions by local ones

Location:

palm/trunk/SOURCE

Files:

• chem_emissions_mod.f90 (modified) (4 diffs)
• chemistry_model_mod.f90 (modified) (2 diffs)

palm/trunk/SOURCE/chem_emissions_mod.f90

@@ -27 +27 @@
 ! -----------------
 ! $Id$
+! Replace global arrays for emissions by local ones.
+! 
+! 4144 2019-08-06 09:11:47Z raasch
 ! relational operators .EQ., .NE., etc. replaced by ==, /=, etc.
 ! 
@@ -860 +863 @@
 
                 IF  (  .NOT.  ALLOCATED( emis_distribution) )  THEN
-                   ALLOCATE( emis_distribution(1,0:ny,0:nx,n_matched_vars) )
+                   ALLOCATE( emis_distribution(1,nys:nyn,nxl:nxr,n_matched_vars) )
                 ENDIF
 
@@ -868 +871 @@
 
                 IF  (  .NOT.  ALLOCATED( emis_distribution) )  THEN
-                   ALLOCATE( emis_distribution(1,0:ny,0:nx,n_matched_vars) )
+                   ALLOCATE( emis_distribution(1,nys:nyn,nxl:nxr,n_matched_vars) )
                 ENDIF
 
@@ -876 +879 @@
 
                 IF  (  .NOT.  ALLOCATED( emis_distribution) )  THEN
-                   ALLOCATE( emis_distribution(nzb:nzt+1,0:ny,0:nx,n_matched_vars) )
+!
+!--                Note, at the moment emissions are considered only by surface fluxes
+!--                rather than by volume sources. Therefore, no vertical dimension is 
+!--                required and is thus allocated with 1. Later when volume sources
+!--                are considered, the vertical dimension will increase.                 
+                   !ALLOCATE( emis_distribution(nzb:nzt+1,nys:nyn,nxl:nxr,n_matched_vars) )
+                   ALLOCATE( emis_distribution(1,nys:nyn,nxl:nxr,n_matched_vars) )
                 ENDIF
  

palm/trunk/SOURCE/chemistry_model_mod.f90

@@ -27 +27 @@
 ! -----------------
 ! $Id$
+! Bugfix in decycling
+! 
+! 4115 2019-07-24 12:50:49Z suehring
 ! Fix faulty IF statement in decycling initialization
 ! 
@@ -2729 +2732 @@
           DO WHILE ( TRIM( cs_name( lsp_usr ) ) /= 'novalue' )
              IF ( TRIM(chem_species(lsp)%name) == TRIM(cs_name(lsp_usr)) )  THEN
-
-                CALL chem_boundary_conds( chem_species(lsp)%conc_p,                     &
-                                                  chem_species(lsp)%conc_pr_init ) 
+!
+!--             As chem_exchange_horiz_bounds is called at the beginning
+!--             of prognostic_equations, boundary conditions are set on 
+!--             %conc. 
+                CALL chem_boundary_conds( chem_species(lsp)%conc,              &
+                                          chem_species(lsp)%conc_pr_init ) 
              
              ENDIF
-             lsp_usr = lsp_usr +1
+             lsp_usr = lsp_usr + 1
           ENDDO