Changeset 4104

Timestamp:

Jul 17, 2019 5:08:20 PM (5 years ago)

Author:

suehring

Message:

initialization of index space for boundary data structure accidantly run over ghost points, causing a segmentation fault

File:

• palm/trunk/SOURCE/surface_mod.f90 (modified) (5 diffs)

palm/trunk/SOURCE/surface_mod.f90

@@ -26 +26 @@
 ! -----------------
 ! $Id$
+! Bugfix, initialization of index space for boundary data structure accidantly
+! run over ghost points, causing a segmentation fault.
+! 
+! 3943 2019-05-02 09:50:41Z maronga
 ! - Revise initialization of the boundary data structure
 ! - Add new data structure to set boundary conditions at vertical walls
@@ -747 +751 @@
 !--    Initialize data structure for horizontal surfaces, i.e. count the number
 !--    of surface elements, allocate and initialize the respective index arrays, 
-!--    and set the respective start and end indices at each (j,i)-location.
+!--    and set the respective start and end indices at each (j,i)-location. 
+!--    The index space is defined also over the ghost points, so that e.g. 
+!--    boundary conditions for diagnostic quanitities can be set on ghost  
+!--    points so that no exchange is required any more. 
        DO  l = 0, 1
 !
@@ -819 +826 @@
 !--       Count the number of upward- and downward-facing surfaces on subdomain
           num_v(l) = 0
-          DO  i = nxlg, nxrg
-             DO  j = nysg, nyng
+          DO  i = nxl, nxr
+             DO  j = nys, nyn
                 DO  k = nzb+1, nzt
 !         
@@ -837 +844 @@
           bc_v(l)%ns = num_v(l)
 !
-!--       ALLOCATE arrays for horizontal surfaces
+!--       ALLOCATE arrays for horizontal surfaces. In contrast to the
+!--       horizontal surfaces, the index space is not defined over the 
+!--       ghost points. 
           ALLOCATE( bc_v(l)%i(1:bc_v(l)%ns) )
           ALLOCATE( bc_v(l)%j(1:bc_v(l)%ns) )
           ALLOCATE( bc_v(l)%k(1:bc_v(l)%ns) )
-          ALLOCATE( bc_v(l)%start_index(nysg:nyng,nxlg:nxrg) )
-          ALLOCATE( bc_v(l)%end_index(nysg:nyng,nxlg:nxrg)   )
+          ALLOCATE( bc_v(l)%start_index(nys:nyn,nxl:nxr) )
+          ALLOCATE( bc_v(l)%end_index(nys:nyn,nxl:nxr)   )
           bc_v(l)%start_index = 1
           bc_v(l)%end_index   = 0
@@ -848 +857 @@
           num_v(l)         = 1
           start_index_v(l) = 1
-          DO  i = nxlg, nxrg
-             DO  j = nysg, nyng
+          DO  i = nxl, nxr
+             DO  j = nys, nyn
           
                 num_v_kji(l) = 0