Changeset 3806 for palm/trunk

Timestamp:

Mar 21, 2019 12:45:50 PM (6 years ago)

Author:

raasch

Message:

bugfix: intent of dummy arguments changed to inout, additional check for lateral boundary conditions added

Location:

palm/trunk/SOURCE

Files:

• module_interface.f90 (modified) (3 diffs)
• parin.f90 (modified) (2 diffs)

palm/trunk/SOURCE/module_interface.f90

@@ -25 +25 @@
 ! -----------------
 ! $Id$
+! bugfix: intent of dummy arguments changed to inout
+! 
+! 3770 2019-02-28 11:22:32Z moh.hefny
 ! removed unused variables in module_interface_check_data_output_ts
 !
@@ -1120 +1123 @@
 
 
-    LOGICAL,           INTENT(OUT) ::  found    !< flag if variable was found
+    LOGICAL, INTENT(INOUT) ::  found    !< flag if variable was found
 
     IF ( .NOT. found )  CALL bio_rrd_global( found ) ! ToDo: change interface to pass variable
@@ -1171 +1174 @@
 
 
-    INTEGER(iwp),      INTENT(IN)  ::  map_index    !<
-    INTEGER(iwp),      INTENT(IN)  ::  nxlc         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nxlf         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nxl_on_file  !<
-    INTEGER(iwp),      INTENT(IN)  ::  nxrc         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nxrf         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nxr_on_file  !<
-    INTEGER(iwp),      INTENT(IN)  ::  nync         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nynf         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nyn_on_file  !<
-    INTEGER(iwp),      INTENT(IN)  ::  nysc         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nysf         !<
-    INTEGER(iwp),      INTENT(IN)  ::  nys_on_file  !<
-    LOGICAL,           INTENT(OUT) ::  found        !< flag if variable was found
+    INTEGER(iwp), INTENT(IN)  ::  map_index    !<
+    INTEGER(iwp), INTENT(IN)  ::  nxlc         !<
+    INTEGER(iwp), INTENT(IN)  ::  nxlf         !<
+    INTEGER(iwp), INTENT(IN)  ::  nxl_on_file  !<
+    INTEGER(iwp), INTENT(IN)  ::  nxrc         !<
+    INTEGER(iwp), INTENT(IN)  ::  nxrf         !<
+    INTEGER(iwp), INTENT(IN)  ::  nxr_on_file  !<
+    INTEGER(iwp), INTENT(IN)  ::  nync         !<
+    INTEGER(iwp), INTENT(IN)  ::  nynf         !<
+    INTEGER(iwp), INTENT(IN)  ::  nyn_on_file  !<
+    INTEGER(iwp), INTENT(IN)  ::  nysc         !<
+    INTEGER(iwp), INTENT(IN)  ::  nysf         !<
+    INTEGER(iwp), INTENT(IN)  ::  nys_on_file  !<
+    LOGICAL,      INTENT(INOUT) ::  found        !< flag if variable was found
 
     REAL(wp), DIMENSION(nys_on_file-nbgp:nyn_on_file+nbgp,nxl_on_file-nbgp:nxr_on_file+nbgp), INTENT(OUT) :: tmp_2d   !<

palm/trunk/SOURCE/parin.f90

@@ -25 +25 @@
 ! -----------------
 ! $Id$
+! additional check for lateral boundary conditions added
+! 
+! 3747 2019-02-16 15:15:23Z gronemeier
 ! removed setting of parameter region
 ! 
@@ -1029 +1032 @@
           IF ( bc_ns == 'radiation/dirichlet' )  bc_ns_raddir = .TRUE.
 !
+!--       Radiation-Dirichlet conditions are allowed along one of the horizontal directions only.
+!--       In general, such conditions along x and y may work, but require a) some code changes
+!--       (e.g. concerning allocation of c_u, c_v ... arrays), and b) a careful model setup by the
+!--       user, in order to guarantee that there is a clearly defined outflow at two sides.
+!--       Otherwise, the radiation condition may produce wrong results.
+          IF ( ( bc_lr_dirrad .OR. bc_lr_raddir )  .AND.  ( bc_ns_dirrad .OR. bc_ns_raddir ) )  THEN
+             message_string = 'bc_lr = "' // TRIM( bc_lr ) // '" and bc_ns = "' //                 &
+                              TRIM( bc_ns ) // '" are not allowed to be set at the same time'
+             CALL message( 'parin', 'PA0589', 1, 2, 0, 6, 0 )
+          ENDIF
+!
 !--       Check in case of initial run, if the grid point numbers are well
 !--       defined and allocate some arrays which are already needed in