Changeset 3754 for palm

Timestamp:

Feb 19, 2019 5:02:26 PM (6 years ago)

Author:

kanani

Message:

Bugfixes for calculation and I/O of view factors

File:

• palm/trunk/SOURCE/radiation_model_mod.f90 (modified) (11 diffs)

palm/trunk/SOURCE/radiation_model_mod.f90

@@ -28 +28 @@
 ! -----------------
 ! $Id$
+! (resler, pavelkrc)
+! Bugfixes: add further required MRT factors to read/write_svf,
+! fix for aggregating view factors to eliminate local noise in reflected 
+! irradiance at mutually close surfaces (corners, presence of trees) in the 
+! angular discretization scheme.
+!
+! 3752 2019-02-19 09:37:22Z resler
 ! added read/write number of MRT factors to the respective routines
 !
@@ -6745 +6752 @@
                CALL quicksort_itarget(itarget,vffrac,ztransp,1,nzn*naz)
 !
+!--            For aggregation, we need fractions multiplied by transmissivities
+               ztransp(:) = vffrac(:) * ztransp(:)
+!
 !--            find the first valid position
                itarg0 = 1
@@ -6758 +6768 @@
                      IF ( itarget(i+1) == itarget(i) )  THEN
                         vffrac(i+1) = vffrac(i+1) + vffrac(i)
+                        ztransp(i+1) = ztransp(i+1) + ztransp(i)
                         CYCLE
                      ENDIF
@@ -6790 +6801 @@
                   asvf(nsvfl)%isurfs = itarget(i)
                   asvf(nsvfl)%rsvf = vffrac(i)
-                  asvf(nsvfl)%rtransp = ztransp(i)
+                  asvf(nsvfl)%rtransp = ztransp(i) / vffrac(i)
                END DO
 
@@ -7697 +7708 @@
       ENDIF
 
-      IF ( yxdir(2) >= 0._wp )  THEN
+      IF ( yxdir(2) > 0._wp )  THEN
           bdydim = nx + .5_wp !< east global boundary
           crossdist(2) = (bdydim - yxorigin(2)) / yxdir(2)
@@ -7792 +7803 @@
          ENDIF
 
-         IF ( ABS(distance - nextdist) < eps )  EXIT
+         IF ( nextdist + eps >= distance )  EXIT
 
          IF ( rad_angular_discretization  .AND.  calc_svf )  THEN
@@ -8283 +8294 @@
 ! Description:
 ! ------------
-!> Soubroutine reads svf and svfsurf data from saved file
+!> Reads svf, svfsurf, csf, csfsurf and mrt factors data from saved file
 !> SVF means sky view factors and CSF means canopy sink factors
 !------------------------------------------------------------------------------!
@@ -8411 +8422 @@
 
              IF ( nmrtbl > 0 )  THEN
+                READ(88) mrtsky
+                READ(88) mrtskyt
+                READ(88) mrtdsit
+             ENDIF
+
+             IF ( nmrtf > 0 )  THEN
                 ALLOCATE ( mrtf(nmrtf) )
                 ALLOCATE ( mrtft(nmrtf) )
@@ -8436 +8453 @@
 ! Description:
 ! ------------
-!> Subroutine stores svf, svfsurf, csf and csfsurf data to a file.
+!> Subroutine stores svf, svfsurf, csf, csfsurf and mrt data to a file.
 !------------------------------------------------------------------------------!
     SUBROUTINE radiation_write_svf
@@ -8469 +8486 @@
              ENDIF
              IF ( nmrtbl > 0 )  THEN
+                WRITE ( 89 ) mrtsky
+                WRITE ( 89 ) mrtskyt
+                WRITE ( 89 ) mrtdsit
+             ENDIF
+             IF ( nmrtf > 0 )  THEN
                  WRITE ( 89 )  mrtf
                  WRITE ( 89 )  mrtft                
@@ -8483 +8505 @@
        ENDDO
     END SUBROUTINE radiation_write_svf
+
 
 !------------------------------------------------------------------------------!