Changeset 3288 for palm

Timestamp:

Sep 28, 2018 10:23:08 AM (6 years ago)

Author:

suehring

Message:

Bugfix in allocation of mean_inflow_profiles in case of restarts

Location:

palm/trunk/SOURCE

Files:

• init_3d_model.f90 (modified) (4 diffs)
• modules.f90 (modified) (2 diffs)
• read_restart_data_mod.f90 (modified) (2 diffs)
• synthetic_turbulence_generator_mod.f90 (modified) (10 diffs)

palm/trunk/SOURCE/init_3d_model.f90

@@ -20 +20 @@
 ! Current revisions:
 ! ------------------
-! 
+! Introduce module parameter for number of inflow profiles
 ! 
 ! Former revisions:
@@ -798 +798 @@
     ALLOCATE( drho_air(nzb:nzt+1) )
     ALLOCATE( drho_air_zw(nzb:nzt+1) )
-
 !
 !-- Density profile calculation for anelastic approximation
@@ -1235 +1234 @@
              ENDDO
           ENDIF
-
 !
 !--       Set velocity components at non-atmospheric / oceanic grid points to 
@@ -1638 +1636 @@
 !--       profiles from the prerun. Alternatively, prescribed profiles
 !--       for u,v-components can be used.
-          ALLOCATE( mean_inflow_profiles(nzb:nzt+1,7) )
+          ALLOCATE( mean_inflow_profiles(nzb:nzt+1,1:num_mean_inflow_profiles) )
 
           IF ( use_prescribed_profile_data )  THEN

palm/trunk/SOURCE/modules.f90

@@ -20 +20 @@
 ! Current revisions:
 ! ------------------
-! 
+! +num_mean_inflow_profiles
 ! 
 ! Former revisions:
@@ -1203 +1203 @@
     INTEGER(iwp) ::  n_sor                             !< number of iterations to be used in SOR-scheme
     INTEGER(iwp) ::  normalizing_region = 0            !< namelist parameter
+    INTEGER(iwp) ::  num_mean_inflow_profiles = 7      !< number of mean inflow profiles in case of turbulent inflow
     INTEGER(iwp) ::  num_leg=0                         !< number of different legs in virtual flight measurements
     INTEGER(iwp) ::  num_var_fl                        !< number of sampling/output variables in virtual flight measurements

palm/trunk/SOURCE/read_restart_data_mod.f90

@@ -20 +20 @@
 ! Current revisions:
 ! -----------------
-! 
+! Introduce module parameter for number of inflow profiles
 ! 
 ! Former revisions:
@@ -460 +460 @@
              CASE ( 'mean_inflow_profiles' )
                 IF ( .NOT. ALLOCATED( mean_inflow_profiles ) )  THEN
-                   ALLOCATE( mean_inflow_profiles(0:nz+1,7) )
+                   ALLOCATE( mean_inflow_profiles(0:nz+1,1:num_mean_inflow_profiles) )
                 ENDIF
                 READ ( 13 )  mean_inflow_profiles

palm/trunk/SOURCE/synthetic_turbulence_generator_mod.f90

@@ -20 +20 @@
 ! Current revisions:
 ! -----------------
-! 
+! Introduce module parameter for number of inflow profiles
 ! 
 ! Former revisions:
@@ -152 +152 @@
 
     USE control_parameters,                                                    &
-        ONLY:  initializing_actions, message_string, syn_turb_gen
+        ONLY:  initializing_actions, num_mean_inflow_profiles, message_string, &
+               syn_turb_gen
 
     USE cpulog,                                                                &
@@ -439 +440 @@
 
     USE arrays_3d,                                                             &
-        ONLY:  ddzw, u_init, v_init, zu
+        ONLY:  dzw, ddzw, u_init, v_init, zu, zw
 
     USE control_parameters,                                                    &
@@ -445 +446 @@
 
     USE grid_variables,                                                        &
-        ONLY:  ddx, ddy
+        ONLY:  ddx, ddy, dx, dy
 
     USE indices,                                                               &
@@ -510 +511 @@
 
     IF ( .NOT. ALLOCATED( mean_inflow_profiles ) )                             &
-       ALLOCATE( mean_inflow_profiles(nzb:nzt+1,5) )
+       ALLOCATE( mean_inflow_profiles(nzb:nzt+1,1:num_mean_inflow_profiles) )
 
     ALLOCATE ( a11(nzb:nzt+1), a21(nzb:nzt+1), a22(nzb:nzt+1),                 &
@@ -528 +529 @@
     IF ( MOD( nz , pdims(1) ) /= 0  .AND.  myidx == id_stg_right )             &
        nzt_x_stg = nzt_x_stg + myidx * ( nnz - INT( nnz ) )
-!        nzt_x_stg = myidx * nnz + MOD( nz , pdims(1) )
 
     IF ( nesting_offline   .OR.  ( child_domain  .AND.  rans_mode_parent       &
@@ -538 +538 @@
        IF ( MOD( nz , pdims(2) ) /= 0  .AND.  myidy == id_stg_north )          &
           nzt_y_stg = nzt_y_stg + myidy * ( nnz - INT( nnz ) )
-!           nzt_y_stg = myidy * nnz + MOD( nz , pdims(2) )
     ENDIF
 
@@ -670 +669 @@
     ELSE
 !
-!--    Set-up defaul length scales. Assume exponentially decreasing length
-!--    scales and isotropic turbulence.
+!--    Set-up default turbulent length scales. From the numerical point of
+!--    view the imposed perturbations should not be immediately dissipated
+!--    by the numerics. The numerical dissipation, however, acts on scales
+!--    up to 8 x the grid spacing. For this reason, set the turbulence 
+!--    length scale to 8 time the grid spacing. Further, above the boundary
+!--    layer height, set turbulence lenght scales to zero (equivalent to not
+!--    imposing any perturbations) in order to save computational costs. 
 !--    Typical length (time) scales of 100 m (s) should be a good compromise
 !--    between all stratrifications. Near-surface variances are fixed to
@@ -684 +688 @@
                                   zu(k) > 0.3 * zu(nzt)                        &
                                 )
-          length_scale_z = length_scale_surface * EXP( dum_exp )
+          length_scale_z = 8.0_wp * MIN( dx, dy, dzw(k) )
+          
+!           IF ( zu(k) > zi_richardson )  
 
           nux(k) = MAX( INT( length_scale_z * ddx     ), 1 )
@@ -709 +715 @@
 
        ENDDO
+       
        nux(nzb) = nux(nzb+1)
        nuy(nzb) = nuy(nzb+1)