Changeset 4722 for palm/trunk

Timestamp:

Oct 5, 2020 11:03:14 AM (4 years ago)

Author:

suehring

Message:

Bugfix in building mapping when static driver is available but no actual building is present within the model domain

File:

• palm/trunk/SOURCE/init_grid.f90 (modified) (5 diffs)

palm/trunk/SOURCE/init_grid.f90

@@ -24 +24 @@
 ! -----------------
 ! $Id$
+! Bugfix in building mapping when static driver is available but no actual building is present
+! within the model domain
+!
+! 4691 2020-09-22 14:38:38Z suehring
 ! Reference model topography to the lowest grid point also in ASCII input case
 !
@@ -903 +907 @@
     IMPLICIT NONE
 
+    INTEGER(iwp) ::  dim_builds       !< total number of buildings within the model domain
     INTEGER(iwp) ::  i                !< running index along x-direction
     INTEGER(iwp) ::  j                !< running index along y-direction
@@ -1099 +1104 @@
 !
 !--       Determine maximumum terrain height occupied by the respective building and temporalily
-!--       store on oro_max.
-          ALLOCATE( oro_max_l(1:SIZE(build_ids_final)) )
-          ALLOCATE( oro_max(1:SIZE(build_ids_final))   )
+!--       store on oro_max. Before, check whether any buildings are defined within the domain.
+          IF ( ALLOCATED( build_ids_final ) )  THEN
+             dim_builds = SIZE(build_ids_final)
+          ELSE
+             dim_builds = 0
+          ENDIF
+
+          ALLOCATE( oro_max_l(1:dim_builds) )
+          ALLOCATE( oro_max(1:dim_builds)   )
           oro_max_l = 0.0_wp
 
-          DO  nr = 1, SIZE(build_ids_final)
+          DO  nr = 1, dim_builds
              oro_max_l(nr) = MAXVAL( MERGE( terrain_height_f%var(nys:nyn,nxl:nxr),                 &
                                               0.0_wp,                                              &
@@ -1112 +1123 @@
 
 #if defined( __parallel )
-          IF ( SIZE(build_ids_final) >= 1 )  THEN
+          IF ( dim_builds >= 1 )  THEN
              CALL MPI_ALLREDUCE( oro_max_l, oro_max, SIZE( oro_max ), MPI_REAL, MPI_MAX, comm2d,   &
                                  ierr )
@@ -1125 +1136 @@
 !--       terrain or
           oro_max_l = 0.0
-          DO  nr = 1, SIZE(build_ids_final)
+          DO  nr = 1, dim_builds
              DO  k = nzb, nzt
                 IF ( zu(k) - ocean_offset <= oro_max(nr) )  oro_max_l(nr) = zw(k) - ocean_offset