Changeset 1749

Timestamp:

Feb 9, 2016 12:19:56 PM (9 years ago)

Author:

raasch

Message:

further OpenACC adjustments and one bugfix

Location:

palm/trunk/SOURCE

Files:

• fft_xy.f90 (modified) (2 diffs)
• surface_layer_fluxes.f90 (modified) (12 diffs)

palm/trunk/SOURCE/fft_xy.f90

@@ -19 +19 @@
 ! Current revisions:
 ! -----------------
-! 
+! small OpenACC bugfix
 ! 
 ! Former revisions:
@@ -1072 +1072 @@
           ar_tmp  !<
        ! following does not work for PGI 14.1 -> to be removed later
-       !$acc declare create( ar_tmp )
+       ! !$acc declare create( ar_tmp )
 #endif
 

palm/trunk/SOURCE/surface_layer_fluxes.f90

@@ -19 +19 @@
 ! Current revisions:
 ! ------------------
-! 
+! further OpenACC adjustments
 !
 ! Former revisions:
@@ -512 +512 @@
 
           !$OMP PARALLEL DO PRIVATE( k, z_mo )
-          !# WARNING: does not work on GPU so far
+          !# WARNING: does not work on GPU so far because of DO-loop with
+          !#          undetermined iterations
           !!!!!!$acc kernels loop
           DO  i = nxl, nxr
@@ -632 +633 @@
 
           !$OMP PARALLEL DO PRIVATE( k, z_mo )
-          !# WARNING: does not work on GPU so far
+          !# WARNING: does not work on GPU so far because of DO WHILE construct
           !!!!!!$acc kernels loop
           DO  i = nxl, nxr
@@ -726 +727 @@
 
        !$OMP PARALLEL DO PRIVATE( k, z_mo )
-       ! ### WARNING: does not work on GPU because of function calls
-       !!!!!$acc kernels loop
-       !$acc update host( ol, uv_total )
+       !$acc kernels loop present( nzb_s_inner, ol, us, uv_total, zu, zw, z0 ) private( j, k, z_mo )
        DO  i = nxlg, nxrg
           DO  j = nysg, nyng
@@ -742 +741 @@
           ENDDO
        ENDDO
-       !$acc update device( us )
 
     END SUBROUTINE calc_us
@@ -808 +806 @@
 
           !$OMP PARALLEL DO PRIVATE( k, z_mo )
-          ! ### WARNING: leads to severe compile error
-          !!!!$acc kernels loop
+          !$acc kernels loop present( nzb_s_inner, ol, pt, pt1, ts, zu, zw, z0h ) private( j, k, z_mo )
           DO  i = nxlg, nxrg
              DO  j = nysg, nyng
@@ -862 +859 @@
 
              !$OMP PARALLEL DO PRIVATE( e_s, k, z_mo )
-             ! ### WARNING: leads to severe compile error
-             !!!!$acc kernels loop independent
+             !$acc kernels loop independent present( nzb_s_inner, ol, pt, q, qs, qv1, zu, zw, z0h ) private( e_s, j, k, z_mo )
              DO  i = nxlg, nxrg
-                !!!!$acc loop independent
+                !$acc loop independent
                 DO  j = nysg, nyng
 
@@ -905 +901 @@
 
           !$OMP PARALLEL DO PRIVATE( k, z_mo )
-          ! ### WARNING: leads to severe compile error
-          !!!!!$acc kernels loop independent
+          !$acc kernels loop independent present( nr, nrs, nzb_s_inner, ol, qr, qrs, zu, zw, z0h ) private( j, k, z_mo )
           DO  i = nxlg, nxrg
-             !!!!$acc loop independent
+             !$acc loop independent
              DO  j = nysg, nyng
 
@@ -914 +909 @@
                 z_mo = zu(k+1) - zw(k)
 
-                   qrs(j,i) = kappa * ( qr(k+1,j,i) - qr(k,j,i) )              &
-                                     / ( LOG( z_mo / z0h(j,i) )                &
-                                         - psi_h( z_mo / ol(j,i) )             &
-                                         + psi_h( z0h(j,i) / ol(j,i) ) )
-
-                   nrs(j,i) = kappa * ( nr(k+1,j,i) - nr(k,j,i) )              &
-                                     / ( LOG( z_mo / z0h(j,i) )                &
-                                         - psi_h( z_mo / ol(j,i) )             &
-                                         + psi_h( z0h(j,i) / ol(j,i) ) )
+                qrs(j,i) = kappa * ( qr(k+1,j,i) - qr(k,j,i) )              &
+                                 / ( LOG( z_mo / z0h(j,i) )                 &
+                                     - psi_h( z_mo / ol(j,i) )              &
+                                     + psi_h( z0h(j,i) / ol(j,i) ) )
+
+                nrs(j,i) = kappa * ( nr(k+1,j,i) - nr(k,j,i) )              &
+                                 / ( LOG( z_mo / z0h(j,i) )                 &
+                                     - psi_h( z_mo / ol(j,i) )              &
+                                     + psi_h( z0h(j,i) / ol(j,i) ) )
              ENDDO
           ENDDO
@@ -945 +940 @@
 !--    First compute the corresponding component of u* and square it.
        !$OMP PARALLEL DO PRIVATE( k, ol_mid, z_mo )
-       ! ### WARNING: leads to severe compile error
-       !!!!!$acc kernels loop
-       !$acc update host( ol, u, us, v )
+       !$acc kernels loop present( nzb_u_inner, ol, u, us, usws, zu, zw, z0 ) private( j, k, z_mo )
        DO  i = nxl, nxr
           DO  j = nys, nyn
@@ -974 +967 @@
 !--    First compute the corresponding component of u* and square it.
        !$OMP PARALLEL DO PRIVATE( k, ol_mid, z_mo )
-       ! ### WARNING: leads to severe compile error
-       !!!!!!$acc kernels loop
+       !$acc kernels loop present( nzb_v_inner, ol, v, us, vsws, zu, zw, z0 ) private( j, k, ol_mid, z_mo )
        DO  i = nxl, nxr
           DO  j = nys, nyn
@@ -1001 +993 @@
 !
 !--    Exchange the boundaries for the momentum fluxes (is this still required?)
-       !!!!!!!!$acc update host( usws, vsws )
+       !$acc update host( usws, vsws )
        CALL exchange_horiz_2d( usws )
        CALL exchange_horiz_2d( vsws )