Changeset 667 for palm/trunk/SOURCE/exchange_horiz_2d.f90

Timestamp:

Dec 23, 2010 12:06:00 PM (13 years ago)

Author:

suehring

Message:

summary:

---

Gryschka:

• Coupling with different resolution and different numbers of PEs in ocean and atmosphere is available
• Exchange of u and v from ocean surface to atmosphere surface
• Mirror boundary condition for u and v at the bottom are replaced by dirichlet boundary conditions
• Inflow turbulence is now defined by flucuations around spanwise mean
• Bugfixes for cyclic_fill and constant_volume_flow

Suehring:

• New advection added ( Wicker and Skamarock 5th order ), therefore:
  • New module advec_ws.f90
  • Modified exchange of ghost boundaries.
  • Modified evaluation of turbulent fluxes
  • New index bounds nxlg, nxrg, nysg, nyng

advec_ws.f90

---

Advection scheme for scalars and momentum using the flux formulation of
Wicker and Skamarock 5th order.
Additionally the module contains of a routine using for initialisation and
steering of the statical evaluation. The computation of turbulent fluxes takes
place inside the advection routines.
In case of vector architectures Dirichlet and Radiation boundary conditions are
outstanding and not available. Furthermore simulations within topography are
not possible so far. A further routine local_diss_ij is available and is used
if a control of dissipative fluxes is desired.

check_parameters.f90

---

Exchange of parameters between ocean and atmosphere via PE0
Check for illegal combination of ws-scheme and timestep scheme.
Check for topography and ws-scheme.
Check for not cyclic boundary conditions in combination with ws-scheme and
loop_optimization = 'vector'.
Check for call_psolver_at_all_substeps and ws-scheme for momentum_advec.

Different processor/grid topology in atmosphere and ocean is now allowed!
Bugfixes in checking for conserve_volume_flow_mode.

exchange_horiz.f90

---

Dynamic exchange of ghost points with nbgp_local to ensure that no useless
ghost points exchanged in case of multigrid. type_yz(0) and type_xz(0) used for
normal grid, the remaining types used for the several grid levels.
Exchange is done via MPI-Vectors with a dynamic value of ghost points which
depend on the advection scheme. Exchange of left and right PEs is 10% faster
with MPI-Vectors than without.

flow_statistics.f90

---

When advection is computed with ws-scheme, turbulent fluxes are already
computed in the respective advection routines and buffered in arrays
sums_xxxx_ws_l(). This is due to a consistent treatment of statistics
with the numerics and to avoid unphysical kinks near the surface. So some if-
requests has to be done to dicern between fluxes from ws-scheme other advection
schemes. Furthermore the computation of z_i is only done if the heat flux
exceeds a minimum value. This affects only simulations of a neutral boundary
layer and is due to reasons of computations in the advection scheme.

inflow_turbulence.f90

---

Using nbgp recycling planes for a better resolution of the turbulent flow near
the inflow.

init_grid.f90

---

Definition of new array bounds nxlg, nxrg, nysg, nyng on each PE.
Furthermore the allocation of arrays and steering of loops is done with these
parameters. Call of exchange_horiz are modified.
In case of dirichlet bounday condition at the bottom zu(0)=0.0
dzu_mg has to be set explicitly for a equally spaced grid near bottom.
ddzu_pres added to use a equally spaced grid near bottom.

init_pegrid.f90

---

Moved determination of target_id's from init_coupling
Determination of parameters needed for coupling (coupling_topology, ngp_a, ngp_o)
with different grid/processor-topology in ocean and atmosphere

Adaption of ngp_xy, ngp_y to a dynamic number of ghost points.
The maximum_grid_level changed from 1 to 0. 0 is the normal grid, 1 to
maximum_grid_level the grids for multigrid, in which 0 and 1 are normal grids.
This distinction is due to reasons of data exchange and performance for the
normal grid and grids in poismg.
The definition of MPI-Vectors adapted to a dynamic numer of ghost points.
New MPI-Vectors for data exchange between left and right boundaries added.
This is due to reasons of performance (10% faster).

ATTENTION: nnz_x undefined problem still has to be solved!!!!!!!!
TEST OUTPUT (TO BE REMOVED) logging mpi2 ierr values

parin.f90

---

Steering parameter dissipation_control added in inipar.

Makefile

---

Module advec_ws added.

Modules

---

Removed u_nzb_p1_for_vfc and v_nzb_p1_for_vfc

For coupling with different resolution in ocean and atmophere:
+nx_a, +nx_o, ny_a, +ny_o, ngp_a, ngp_o, +total_2d_o, +total_2d_a,
+coupling_topology

Buffer arrays for the left sided advective fluxes added in arrays_3d.
+flux_s_u, +flux_s_v, +flux_s_w, +diss_s_u, +diss_s_v, +diss_s_w,
+flux_s_pt, +diss_s_pt, +flux_s_e, +diss_s_e, +flux_s_q, +diss_s_q,
+flux_s_sa, +diss_s_sa
3d arrays for dissipation control added. (only necessary for vector arch.)
+var_x, +var_y, +var_z, +gamma_x, +gamma_y, +gamma_z
Default of momentum_advec and scalar_advec changed to 'ws-scheme' .
+exchange_mg added in control_parameters to steer the data exchange.
Parameters +nbgp, +nxlg, +nxrg, +nysg, +nyng added in indices.
flag array +boundary_flags added in indices to steer the degradation of order
of the advective fluxes when non-cyclic boundaries are used.
MPI-datatypes +type_y, +type_y_int and +type_yz for data_exchange added in
pegrid.
+sums_wsus_ws_l, +sums_wsvs_ws_l, +sums_us2_ws_l, +sums_vs2_ws_l,
+sums_ws2_ws_l, +sums_wspts_ws_l, +sums_wssas_ws_l, +sums_wsqs_ws_l
and +weight_substep added in statistics to steer the statistical evaluation
of turbulent fluxes in the advection routines.
LOGICALS +ws_scheme_sca and +ws_scheme_mom added to get a better performance
in prognostic_equations.
LOGICAL +dissipation_control control added to steer numerical dissipation
in ws-scheme.

Changed length of string run_description_header

pres.f90

---

New allocation of tend when ws-scheme and multigrid is used. This is due to
reasons of perforance of the data_exchange. The same is done with p after
poismg is called.
nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng when no
multigrid is used. Calls of exchange_horiz are modified.

bugfix: After pressure correction no volume flow correction in case of
non-cyclic boundary conditions
(has to be done only before pressure correction)

Call of SOR routine is referenced with ddzu_pres.

prognostic_equations.f90

---

Calls of the advection routines with WS5 added.
Calls of ws_statistics added to set the statistical arrays to zero after each
time step.

advec_particles.f90

---

Declaration of de_dx, de_dy, de_dz adapted to additional ghost points.
Furthermore the calls of exchange_horiz were modified.

asselin_filter.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

average_3d_data.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

boundary_conds.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng
Removed mirror boundary conditions for u and v at the bottom in case of
ibc_uv_b == 0. Instead, dirichelt boundary conditions (u=v=0) are set
in init_3d_model

calc_liquid_water_content.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

calc_spectra.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng for
allocation of tend.

check_open.f90

---

Output of total array size was adapted to nbgp.

data_output_2d.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng in loops and
allocation of arrays local_2d and total_2d.
Calls of exchange_horiz are modified.

data_output_2d.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng in loops and
allocation of arrays. Calls of exchange_horiz are modified.
Skip-value skip_do_avs changed to a dynamic adaption of ghost points.

data_output_mask.f90

---

Calls of exchange_horiz are modified.

diffusion_e.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

diffusion_s.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

diffusion_u.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

diffusion_v.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

diffusion_w.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

diffusivities.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

diffusivities.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.
Calls of exchange_horiz are modified.

exchange_horiz_2d.f90

---

Dynamic exchange of ghost points with nbgp, which depends on the advection
scheme. Exchange between left and right PEs is now done with MPI-vectors.

global_min_max.f90

---

Adapting of the index arrays, because MINLOC assumes lowerbound
at 1 and not at nbgp.

init_3d_model.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng in loops and
allocation of arrays. Calls of exchange_horiz are modified.
Call ws_init to initialize arrays needed for statistical evaluation and
optimization when ws-scheme is used.
Initial volume flow is now calculated by using the variable hom_sum.
Therefore the correction of initial volume flow for non-flat topography
removed (removed u_nzb_p1_for_vfc and v_nzb_p1_for_vfc)
Changed surface boundary conditions for u and v in case of ibc_uv_b == 0 from
mirror bc to dirichlet boundary conditions (u=v=0), so that k=nzb is
representative for the height z0

Bugfix: type conversion of '1' to 64bit for the MAX function (ngp_3d_inner)

init_coupling.f90

---

determination of target_id's moved to init_pegrid

init_pt_anomaly.f90

---

Call of exchange_horiz are modified.

init_rankine.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.
Calls of exchange_horiz are modified.

init_slope.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.

header.f90

---

Output of advection scheme.

poismg.f90

---

Calls of exchange_horiz are modified.

prandtl_fluxes.f90

---

Changed surface boundary conditions for u and v from mirror bc to dirichelt bc,
therefore u(uzb,:,:) and v(nzb,:,:) is now representative for the height z0
nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

production_e.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng

read_3d_binary.f90

---

+/- 1 replaced with +/- nbgp when swapping and allocating variables.

sor.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.
Call of exchange_horiz are modified.
bug removed in declaration of ddzw(), nz replaced by nzt+1

subsidence.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.

sum_up_3d_data.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.

surface_coupler.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng in
MPI_SEND() and MPI_RECV.
additional case for nonequivalent processor and grid topopolgy in ocean and
atmosphere added (coupling_topology = 1)

Added exchange of u and v from Ocean to Atmosphere

time_integration.f90

---

Calls of exchange_horiz are modified.
Adaption to slooping surface.

timestep.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.

user_3d_data_averaging.f90, user_data_output_2d.f90, user_data_output_3d.f90,
user_actions.f90, user_init.f90, user_init_plant_canopy.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.

user_read_restart_data.f90

---

Allocation with nbgp.

wall_fluxes.f90

---

nxl-1, nxr+1, nys-1, nyn+1 replaced by nxlg, nxrg, nysg, nyng.

write_compressed.f90

---

Array bounds and nx, ny adapted with nbgp.

sor.f90

---

bug removed in declaration of ddzw(), nz replaced by nzt+1

Location:

palm/trunk/SOURCE

Files:

• . (modified) (1 prop)
• exchange_horiz_2d.f90 (modified) (10 diffs)

palm/trunk/SOURCE/exchange_horiz_2d.f90

@@ -4 +4 @@
 ! Current revisions:
 ! -----------------
-! 
+! Dynamic exchange of ghost points with nbgp, which depends on the advection
+! scheme. Exchange between left and right PEs is now done with MPI-vectors.
 !
 ! Former revisions:
@@ -37 +38 @@
     IMPLICIT NONE
 
-    REAL ::  ar(nys-1:nyn+1,nxl-1:nxr+1)
+    REAL ::  ar(nysg:nyng,nxlg:nxrg)
+    INTEGER :: i
 
 
@@ -51 +53 @@
 !--    One-dimensional decomposition along y, boundary values can be exchanged
 !--    within the PE memory
-       ar(nys:nyn,nxl-1) = ar(nys:nyn,nxr)
-       ar(nys:nyn,nxr+1) = ar(nys:nyn,nxl)
+       ar(:,nxl-nbgp:nxl-1) = ar(:,nxr-nbgp+1:nxr)
+       ar(:,nxr+1:nxr+nbgp) = ar(:,nxl:nxl+nbgp-1)
 
     ELSE
 !
 !--    Send left boundary, receive right one
-       CALL MPI_SENDRECV( ar(nys,nxl),   ngp_y, MPI_REAL, pleft,  0, &
-                          ar(nys,nxr+1), ngp_y, MPI_REAL, pright, 0, &
+
+       CALL MPI_SENDRECV( ar(nysg,nxl), 1, type_y, pleft,  0, &
+                          ar(nysg,nxr+1), 1, type_y, pright, 0, &
                           comm2d, status, ierr )
 !
 !--    Send right boundary, receive left one
-       CALL MPI_SENDRECV( ar(nys,nxr),   ngp_y, MPI_REAL, pright,  1, &
-                          ar(nys,nxl-1), ngp_y, MPI_REAL, pleft,   1, &
+       CALL MPI_SENDRECV( ar(nysg,nxr+1-nbgp), 1, type_y, pright,  1, &
+                          ar(nysg,nxlg), 1, type_y, pleft,   1, &
                           comm2d, status, ierr )
     ENDIF
@@ -71 +74 @@
 !--    One-dimensional decomposition along x, boundary values can be exchanged
 !--    within the PE memory
-       ar(nys-1,:) = ar(nyn,:)
-       ar(nyn+1,:) = ar(nys,:)
+       ar(nys-nbgp:nys-1,:) = ar(nyn-nbgp+1:nyn,:)
+       ar(nyn+1:nyn+nbgp,:) = ar(nys:nys+nbgp-1,:)
 
     ELSE
 !
 !--    Send front boundary, receive rear one
-       CALL MPI_SENDRECV( ar(nys,nxl-1),   1, type_x, psouth, 0, &
-                          ar(nyn+1,nxl-1), 1, type_x, pnorth, 0, &
+
+       CALL MPI_SENDRECV( ar(nys,nxlg), 1, type_x, psouth, 0, &        !replace number of sended elements from 
+                          ar(nyn+1,nxlg), 1, type_x, pnorth, 0, &      ! nbgp to 1
                           comm2d, status, ierr )
 !
 !--    Send rear boundary, receive front one
-       CALL MPI_SENDRECV( ar(nyn,nxl-1),   1, type_x, pnorth, 1, &
-                          ar(nys-1,nxl-1), 1, type_x, psouth, 1, &
-                          comm2d, status, ierr )
+       CALL MPI_SENDRECV( ar(nyn+1-nbgp,nxlg), 1, type_x, pnorth, 1, &
+                          ar(nysg,nxlg), 1, type_x, psouth, 1, &
+                          comm2d, status, ierr )
+
     ENDIF
 
@@ -92 +97 @@
 !-- Lateral boundary conditions in the non-parallel case
     IF ( bc_lr == 'cyclic' )  THEN
-       ar(nys:nyn,nxl-1) = ar(nys:nyn,nxr)
-       ar(nys:nyn,nxr+1) = ar(nys:nyn,nxl)
+       ar(:,nxl-nbgp:nxl-1) = ar(:,nxr-nbgp+1:nxr)
+       ar(:,nxr+1:nxr+nbgp) = ar(:,nxl:nxl+nbgp-1)
     ENDIF
 
     IF ( bc_ns == 'cyclic' )  THEN
-       ar(nys-1,:) = ar(nyn,:)
-       ar(nyn+1,:) = ar(nys,:)
-    ENDIF
+       ar(nys-nbgp:nys-1,:) = ar(nyn-nbgp+1:nyn,:)
+       ar(nyn+1:nyn+nbgp,:) = ar(nys:nys+nbgp-1,:)
+    ENDIF
+
 
 #endif
@@ -106 +112 @@
 !-- Neumann-conditions at inflow/outflow in case of non-cyclic boundary
 !-- conditions
-    IF ( inflow_l .OR. outflow_l )  ar(:,nxl-1) = ar(:,nxl)
-    IF ( inflow_r .OR. outflow_r )  ar(:,nxr+1) = ar(:,nxr)
-    IF ( inflow_s .OR. outflow_s )  ar(nys-1,:) = ar(nys,:)
-    IF ( inflow_n .OR. outflow_n )  ar(nyn+1,:) = ar(nyn,:)
-
+    IF ( inflow_l .OR. outflow_l )  THEN
+       DO i=nbgp, 1, -1
+         ar(:,nxl-i) = ar(:,nxl)
+       END DO
+    END IF
+    IF ( inflow_r .OR. outflow_r )  THEN 
+       DO i=1, nbgp
+          ar(:,nxr+i) = ar(:,nxr)
+       END DO
+    END IF
+    IF ( inflow_s .OR. outflow_s )  THEN
+       DO i=nbgp, 1, -1
+         ar(nys-i,:) = ar(nys,:)
+       END DO
+    END IF
+    IF ( inflow_n .OR. outflow_n )  THEN
+       DO i=1, nbgp
+         ar(nyn+i,:) = ar(nyn,:)
+       END DO
+    END IF
     CALL cpu_log( log_point_s(13), 'exchange_horiz_2d', 'stop' )
 
@@ -134 +155 @@
     IMPLICIT NONE
 
-    INTEGER ::  ar(nys-1:nyn+1,nxl-1:nxr+1)
+    REAL ::  ar(nysg:nyng,nxlg:nxrg)
+    INTEGER :: i
+
 
 
@@ -154 +177 @@
 !
 !--    Send left boundary, receive right one
-       CALL MPI_SENDRECV( ar(nys,nxl),   ngp_y, MPI_INTEGER, pleft,  0, &
-                          ar(nys,nxr+1), ngp_y, MPI_INTEGER, pright, 0, &
+       CALL MPI_SENDRECV( ar(nysg,nxl), 1, type_y_int, pleft,  0, &
+                          ar(nysg,nxr+1), 1, type_y_int, pright, 0, &
                           comm2d, status, ierr )
 !
 !--    Send right boundary, receive left one
-       CALL MPI_SENDRECV( ar(nys,nxr),   ngp_y, MPI_INTEGER, pright,  1, &
-                          ar(nys,nxl-1), ngp_y, MPI_INTEGER, pleft,   1, &
-                          comm2d, status, ierr )
+       CALL MPI_SENDRECV( ar(nysg,nxr+1-nbgp), 1, type_y_int, pright,  1, &
+                          ar(nysg,nxlg), 1, type_y_int, pleft,   1, &
+                          comm2d, status, ierr )
+
     ENDIF
 
@@ -168 +192 @@
 !--    One-dimensional decomposition along x, boundary values can be exchanged
 !--    within the PE memory
-       ar(nys-1,:) = ar(nyn,:)
-       ar(nyn+1,:) = ar(nys,:)
+       ar(nysg:nys-1,:) = ar(nyn+1-nbgp:nyn,:)
+       ar(nyn+1:nyng,:) = ar(nys:nys-1+nbgp,:)
+
 
     ELSE
 !
 !--    Send front boundary, receive rear one
-       CALL MPI_SENDRECV( ar(nys,nxl-1),   1, type_x_int, psouth, 0, &
-                          ar(nyn+1,nxl-1), 1, type_x_int, pnorth, 0, &
-                          comm2d, status, ierr )
+       CALL MPI_SENDRECV( ar(nys,nxlg),1, type_x_int, psouth, 0, &
+                          ar(nyn+1,nxlg),1, type_x_int, pnorth, 0, &
+                          comm2d, status, ierr )
+
 !
 !--    Send rear boundary, receive front one
-       CALL MPI_SENDRECV( ar(nyn,nxl-1),   1, type_x_int, pnorth, 1, &
-                          ar(nys-1,nxl-1), 1, type_x_int, psouth, 1, &
-                          comm2d, status, ierr )
+       CALL MPI_SENDRECV( ar(nyn+1-nbgp,nxlg), nbgp, type_x_int, pnorth, 1, &
+                          ar(nysg,nxlg), nbgp, type_x_int, psouth, 1, &
+                          comm2d, status, ierr )
+
     ENDIF
 
@@ -194 +221 @@
 
     IF ( bc_ns == 'cyclic' )  THEN
-       ar(nys-1,:) = ar(nyn,:)
-       ar(nyn+1,:) = ar(nys,:)
+       ar(nysg:nys-1,:) = ar(nyn+1-nbgp:nyn,:)
+       ar(nyn+1:nyng,:) = ar(nys:nys-1+nbgp,:)
     ENDIF