Changeset 4238 for palm/trunk/SOURCE/indoor_model_mod.f90

Timestamp:

Sep 25, 2019 4:06:01 PM (5 years ago)

Author:

suehring

Message:

Building data base: Indoor-model parameters for some building types adjusted in order to avoid unrealistically high indoor temperatures (S. Rissmann); Indoor model: Bugfix in determination of minimum facade height and in location message, avoid divisions by zero, minor optimizations; radiation model: Modify check in order to avoid equality comparisons of floating points

File:

• palm/trunk/SOURCE/indoor_model_mod.f90 (modified) (7 diffs)

palm/trunk/SOURCE/indoor_model_mod.f90

@@ -26 +26 @@
 ! -----------------
 ! $Id$
+! - Bugfix in determination of minimum facade height and in location message
+! - Bugfix, avoid division by zero
+! - Some optimization 
+! 
+! 4227 2019-09-10 18:04:34Z gronemeier
 ! implement new palm_date_time_mod
 !
@@ -469 +474 @@
                                                            !< on local subdomain
 
-    CALL location_message( 'initializing indoor model', .FALSE. )
+    CALL location_message( 'initializing indoor model', 'start' )
 !
 !-- Initializing of indoor model is only possible if buildings can be 
@@ -615 +620 @@
     ENDDO
 
-    DO nb = 1, num_build
 #if defined( __parallel ) 
-       CALL MPI_ALLREDUCE( k_min_l(nb), buildings(nb)%kb_min, 1, MPI_INTEGER,  &
-                           MPI_MIN, comm2d, ierr )
-       CALL MPI_ALLREDUCE( k_max_l(nb), buildings(nb)%kb_max, 1, MPI_INTEGER,  &
-                           MPI_MAX, comm2d, ierr )
+    CALL MPI_ALLREDUCE( k_min_l(:), buildings(:)%kb_min, num_build,            &
+                        MPI_INTEGER, MPI_MIN, comm2d, ierr )
+    CALL MPI_ALLREDUCE( k_max_l(:), buildings(:)%kb_max, num_build,            &
+                        MPI_INTEGER, MPI_MAX, comm2d, ierr )
 #else
-       buildings(nb)%kb_min = k_min_l(nb)
-       buildings(nb)%kb_max = k_max_l(nb)
+    buildings(:)%kb_min = k_min_l(:)
+    buildings(:)%kb_max = k_max_l(:)
 #endif
-
-    ENDDO 
 
     DEALLOCATE( k_min_l )
@@ -746 +748 @@
     ENDDO
 !
-!-- Vertical facades!
+!-- Vertical facades
     buildings(:)%num_facades_per_building_v_l = 0
     DO  l = 0, 3
@@ -842 +844 @@
        ENDIF
 !
-! --    Determine volume per facade element (vpf)
+!--    Determine volume per facade element (vpf)
        IF ( buildings(nb)%on_pe )  THEN
           ALLOCATE( buildings(nb)%vpf(buildings(nb)%kb_min:buildings(nb)%kb_max) )
+          buildings(nb)%vpf = 0.0_wp
           
           DO  k = buildings(nb)%kb_min, buildings(nb)%kb_max
-             buildings(nb)%vpf(k) = buildings(nb)%volume(k) /                  &
+!
+!--          In order to avoid division by zero, check if the number of facade
+!--          elements is /= 0. This can e.g. happen if a building is embedded
+!--          in higher terrain and at a given k-level neither horizontal nor
+!--          vertical facade elements are located.
+             IF ( buildings(nb)%num_facade_h(k)                                &
+                + buildings(nb)%num_facade_v(k) > 0 )  THEN  
+                buildings(nb)%vpf(k) = buildings(nb)%volume(k) /               &
                                 REAL( buildings(nb)%num_facade_h(k) +          &
                                       buildings(nb)%num_facade_v(k), KIND = wp )
+             ENDIF
           ENDDO
        ENDIF
@@ -1037 +1048 @@
     ENDDO
 
-    CALL location_message( 'finished', .TRUE. )
+    CALL location_message( 'initializing indoor model', 'finished' )
 
  END SUBROUTINE im_init
@@ -1790 +1801 @@
            IF ( av == 0 ) THEN
               DO  m = 1, surf_usm_h%ns
-                  i = surf_usm_h%i(m) !+ surf_usm_h%ioff
-                  j = surf_usm_h%j(m) !+ surf_usm_h%joff
-                  k = surf_usm_h%k(m) !+ surf_usm_h%koff
-                  local_pf(i,j,k) = surf_usm_h%iwghf_eb(m)
+                 i = surf_usm_h%i(m) !+ surf_usm_h%ioff
+                 j = surf_usm_h%j(m) !+ surf_usm_h%joff
+                 k = surf_usm_h%k(m) !+ surf_usm_h%koff
+                 local_pf(i,j,k) = surf_usm_h%iwghf_eb(m)
               ENDDO
            ENDIF