Changeset 4015 for palm/trunk/SOURCE/pres.f90

Timestamp:

Jun 5, 2019 1:25:35 PM (5 years ago)

Author:

raasch

Message:

all reals changed to double precision in order to work with 32-bit working precision, otherwise calculated time intervals would mostly give zero; variable child_domain_nvn eliminated

File:

• palm/trunk/SOURCE/pres.f90 (modified) (6 diffs)

palm/trunk/SOURCE/pres.f90

@@ -25 +25 @@
 ! -----------------
 ! $Id$
+! variable child_domain_nvn eliminated
+! 
+! 3849 2019-04-01 16:35:16Z knoop
 ! OpenACC port for SPEC
 ! 
@@ -231 +234 @@
     REAL(wp), DIMENSION(1:nzt) ::  w_l_l               !<
 
-    LOGICAL :: child_domain_nvn      !<
-
 
     CALL cpu_log( log_point(8), 'pres', 'start' )
@@ -381 +382 @@
 
 !
-!-- Remove mean vertical velocity in case that Neumann conditions are
-!-- used both at bottom and top boundary, and if not a nested domain in a 
-!-- normal nesting run. In case of vertical nesting, this must be done.
-!-- Therefore an auxiliary logical variable child_domain_nvn is used here, and 
-!-- nvn stands for non-vertical nesting. 
-!-- This cannot be done before the first initial time step because ngp_2dh_outer
+!-- Remove mean vertical velocity in case that Neumann conditions are used both at bottom and top
+!-- boundary. With Neumann conditions at both vertical boundaries, the solver cannot remove
+!-- mean vertical velocities. They should be removed, because incompressibility requires that
+!-- the vertical gradient of vertical velocity is zero. Since w=0 at the solid surface, it must be
+!-- zero everywhere.
+!-- This must not be done in case of a 3d-nesting child domain, because a mean vertical velocity
+!-- can physically exist in such a domain.
+!-- Also in case of offline nesting, mean vertical velocities may exist (and must not be removed),
+!-- caused by horizontal divergence/convergence of the large scale flow that is prescribed at the
+!-- side boundaries.
+!-- The removal cannot be done before the first initial time step because ngp_2dh_outer
 !-- is not yet known then.
-    child_domain_nvn = child_domain
-    IF ( child_domain .AND. nesting_mode == 'vertical' )  THEN
-       child_domain_nvn = .FALSE.
-    ENDIF
-
-    IF ( ibc_p_b == 1  .AND.  ibc_p_t == 1  .AND.  .NOT. nesting_offline  .AND. &
-         .NOT. child_domain_nvn  .AND. intermediate_timestep_count /= 0 )       &
+    IF ( ibc_p_b == 1  .AND.  ibc_p_t == 1  .AND.  .NOT. nesting_offline                           &
+         .AND. .NOT. ( child_domain .AND. nesting_mode /= 'vertical' )                             &
+         .AND. intermediate_timestep_count /= 0 )                                                  &
     THEN
        w_l = 0.0_wp;  w_l_l = 0.0_wp
@@ -400 +402 @@
           DO  j = nys, nyn
              DO  k = nzb+1, nzt
-                w_l_l(k) = w_l_l(k) + w(k,j,i)                                 &
-                                     * MERGE( 1.0_wp, 0.0_wp,                  &
-                                              BTEST( wall_flags_0(k,j,i), 3 )  &
-                                            )
+                w_l_l(k) = w_l_l(k) + w(k,j,i)                                                     &
+                                     * MERGE( 1.0_wp, 0.0_wp, BTEST( wall_flags_0(k,j,i), 3 ) )
              ENDDO
           ENDDO
@@ -409 +409 @@
 #if defined( __parallel )   
        IF ( collective_wait )  CALL MPI_BARRIER( comm2d, ierr )
-       CALL MPI_ALLREDUCE( w_l_l(1), w_l(1), nzt, MPI_REAL, MPI_SUM, &
-                           comm2d, ierr )
+       CALL MPI_ALLREDUCE( w_l_l(1), w_l(1), nzt, MPI_REAL, MPI_SUM, comm2d, ierr )
 #else
        w_l = w_l_l
@@ -420 +419 @@
           DO  j = nysg, nyng
              DO  k = nzb+1, nzt
-                w(k,j,i) = w(k,j,i) - w_l(k)                                   &
-                                     * MERGE( 1.0_wp, 0.0_wp,                  &
-                                              BTEST( wall_flags_0(k,j,i), 3 )  &
-                                            )
+                w(k,j,i) = w(k,j,i) - w_l(k)                                                       &
+                                     * MERGE( 1.0_wp, 0.0_wp, BTEST( wall_flags_0(k,j,i), 3 ) )
              ENDDO
           ENDDO